Assorted improvements #1894
Merged
Assorted improvements #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcadalzo
reviewed
Mar 27, 2023
| @@ -79,6 +79,11 @@ def load_dataset(dataset_config, *args, num_batches=None, check_run=False, **kwa | |||
| if check_run: | |||
| return EvalGenerator(dataset, num_eval_batches=1) | |||
| if num_batches: | |||
| if num_batches > dataset.batches_per_epoch: | |||
There was a problem hiding this comment.
I tested that this works, but this function has become obsolete on the tfdsv4 branch in lieu of this one. I'd suggest also incorporating this change on a branch based off tfdsv4
There was a problem hiding this comment.
this would occur in a separate PR into tfdsv4, though, so I'm good merging this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small unrelated improvements.