Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor BadDet improvements #1942

Merged
merged 5 commits into from
May 26, 2023
Merged

Minor BadDet improvements #1942

merged 5 commits into from
May 26, 2023

Conversation

swsuggs
Copy link
Contributor

@swsuggs swsuggs commented May 25, 2023

Fixed:

  • Potentially misleading error statement
  • source/target class in configs
  • final batch loop does not skip remaining data if there is less than batch_size

@mwartell mwartell mentioned this pull request May 25, 2023
Merged
2 tasks
@swsuggs swsuggs changed the title WIP Minor BadDet improvements Minor BadDet improvements May 26, 2023
christopherwoodall
christopherwoodall approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@christopherwoodall christopherwoodall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christopherwoodall christopherwoodall merged commit 2dda1c3 into twosixlabs:develop May 26, 2023
@swsuggs swsuggs deleted the minor-baddet-improvements branch May 26, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherwoodall christopherwoodall christopherwoodall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swsuggs @christopherwoodall