Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring tag to develop from master #1967

Merged
merged 7 commits into from
Jul 24, 2023

Conversation

mwartell
Copy link
Collaborator

@mwartell mwartell commented Jul 24, 2023

There was a setuptools_scm unhappiness because the v0.18.0 tag lived on master but not develop.

Because a tag applies to one specific commit, merging master into develop gets the tagged commit into branch develop thus allowing work on that branch to see v0.18.0

This happened because I forgot to merge master→develop, and then forgot that I forgot. 😢

mwartell and others added 7 commits May 16, 2023 13:51
@mwartell mwartell changed the base branch from master to develop July 24, 2023 12:48
Copy link
Contributor

@christopherwoodall christopherwoodall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christopherwoodall christopherwoodall merged commit 075c50f into develop Jul 24, 2023
@christopherwoodall christopherwoodall deleted the bring-tag-to-develop-from-master branch July 24, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants