iterate through sys.path instead of just checking cwd #1985
Conversation
| @@ -57,11 +58,18 @@ def create_initial_image(self, size, hsv_lower_bound, hsv_upper_bound): | |||
| patch_base_image_path = os.path.abspath( | |||
| os.path.join(module_folder, self.patch_base_image) | |||
| ) | |||
| # if the image does not exist, check cwd | |||
| # if the image does not exist iterate through path | |||
| if not os.path.exists(patch_base_image_path): | |||
There was a problem hiding this comment.
Would it make sense to combine this conditional (line 62) with the similar one on line 74?
There was a problem hiding this comment.
This can certainly be cleaned up to avoid fallthroughs like this but the second check on 74 is needed to determine if it was in the path. Another option is to use for-break iterating through the path and checking for url only if the loop finishes.
Regardless, I am cleaning this code path up in #1904:
bff3f02#diff-43528b7021f0d40c4760148beb2bdbb8e81013288e0d00e42ff57940600b7d12R124-R167
There was a problem hiding this comment.
I created this PR more as a hotfix so people can use images anywhere off their armory git directory by including it in the local_repo_path since that gets added to your pythonpath. Happy to move the fetch_file_or_url function into this PR to prevent additional changes with #1904
Makes it so you can put
patch_base_imagesfor carla od adv patch in any folder added tolocal_repo_dirin config.