fix: import ts from typescript instead of typescript/lib/tsserver
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for twoslash ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Are any tsserverlibrary specific exports even used? When I looked at the code from the last PR, it sure seemed like they could just use the regular import. |
antfu
changed the title
typescript instead of typescript/lib/tsserver
|
Right, we probably don't need tsserver. It is like that because it was how it was written in TypeScript Website repo. I think we should be good to use |
|
Confirmed that this unblocked me 👍 |
|
I don't really understand how this was needed at the end of the day, given TS is CJS and so this import should be fine, but at least this import wasn't even needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed this to .js instead of 'typescript', as this will work better with versions of TypeScript before 5.3.