feat: Warn about future removal of insecure hashes #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halostatue
reviewed
Dec 10, 2024
internal/chezmoi/sourcestate.go
Outdated
| @@ -1692,20 +1703,23 @@ func (s *SourceState) getExternalData( | |||
| var errs []error | |||
|
|
|||
| if external.Checksum.Size != 0 { | |||
| s.warnFunc("%s: warning: insecure size check will be removed, use a secure hash like SHA256 instead\n", externalRelPath) | |||
There was a problem hiding this comment.
size should be permitted in conjunction with the more secure sha256 et al as it would help prevent length extension attacks. (IIRC, sha384 is resistant.)
There was a problem hiding this comment.
Thanks for the review. I've update the PR to allow size when specified with a secure hash like SHA256, SHA384, or SHA512.
twpayne
force-pushed
the
prep-remove-insecure-hashes
branch
from
06ebe0b to
830fcb8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to remove insecure hashes/checksums in the future.
I suspect that these are rarely used, but I don't want to break people who are relying on this feature now, so this PR only adds a warning for now.