Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update txeh.go #16

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Update txeh.go #16

merged 1 commit into from
Nov 16, 2022

Conversation

docooler
Copy link
Contributor

fix ipv4 and ipv6 using localhost at same time

fix ipv4 and ipv6 using localhost at same time
@cjimti
Copy link
Member

cjimti commented Aug 17, 2021

@docooler please provide an explanation on this and an example use case I can test. This could be a breaking change for some people so I want to better understand what you are trying do.

@docooler
Copy link
Contributor Author

docooler commented Aug 18, 2021

we have below /etc/hosts
#localhost name resolution is handled within DNS itself.
127.0.0.1 localhost
::1 localhost

using cli txeh add 127.0.0.1 localhost.localdomain add a new host to ipv4 localhost.
it will change to below
#localhost name resolution is handled within DNS itself.
127.0.0.1 localhost localhost.localdomain
::1 localhost

using cli txeh add ::1 localhost.localdomain add a new host to ipv6 localhost.
it will change to below
#localhost name resolution is handled within DNS itself.
127.0.0.1 localhost
::1 localhost localhost.localdomain

But I expect it change to
#localhost name resolution is handled within DNS itself.
127.0.0.1 localhost localhost.localdomain
::1 localhost localhost.localdomain

so I commit this PR.
thx

@cjimti cjimti merged commit b4a4cf7 into txn2:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants