Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings from Ruby 2.7 #19

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Fix warnings from Ruby 2.7 #19

merged 2 commits into from
Jan 29, 2020

Conversation

AlexWayfer
Copy link
Contributor

@AlexWayfer AlexWayfer commented Jan 23, 2020 •
edited
Loading

Add specs for it.

tycooon
tycooon requested changes Jan 23, 2020
View reviewed changes
Copy link
Owner

@tycooon tycooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it fails in older rubies.

@AlexWayfer
Copy link
Contributor Author

And cache, cache is depending on args and it's wrong now. I'll add tests.

@AlexWayfer AlexWayfer force-pushed the fix_warnings_from_ruby_2.7 branch from 5df8b05 to 4c1f9b7 Compare January 23, 2020 15:58
@AlexWayfer
Copy link
Contributor Author

Looks like it fails in older rubies.

Done. It's strange, I didn't find anything related in Ruby 2.5.0 changes.

And cache, cache is depending on args and it's wrong now. I'll add tests.

Done.

@tycooon
Copy link
Owner

tycooon commented Jan 23, 2020 •
edited
Loading

Done. It's strange, I didn't find anything related in Ruby 2.5.0 changes.

AFAIR there were some bugfixes in handling kwargs.

@tycooon
Copy link
Owner

tycooon commented Jan 23, 2020

Now rubocop is unhappy though :(

@AlexWayfer
Copy link
Contributor Author

AlexWayfer commented Jan 23, 2020 •
edited
Loading

Now rubocop is unhappy though :(

Oh, not a problem. I'm used to 80-symbols lines or not limit at all. Didn't notice offenses, sorry. I'll fix that.

@AlexWayfer
Copy link
Contributor Author

And it's hard to test:

> bundle exec rubocop 
Error: The `Naming/UncommunicativeMethodParamName` cop has been renamed to `Naming/MethodParameterName`.
(obsolete configuration found in .rubocop.yml, please update it)

😬

@AlexWayfer AlexWayfer force-pushed the fix_warnings_from_ruby_2.7 branch from 4c1f9b7 to a4bc277 Compare January 23, 2020 23:39
@AlexWayfer
Copy link
Contributor Author

private method `define_method' called (Ruby 2.4)

Okay then!

@AlexWayfer
Fix warnings from Ruby 2.7
559ef78 
Add specs for it.
@AlexWayfer AlexWayfer force-pushed the fix_warnings_from_ruby_2.7 branch from a4bc277 to 559ef78 Compare January 24, 2020 00:13
@AlexWayfer
Copy link
Contributor Author

And the problem with:

This branch is out-of-date with the base branch

because of ff64398#commitcomment-36941780

@tycooon tycooon merged commit a4907c8 into tycooon:master Jan 29, 2020
@tycooon
Copy link
Owner

tycooon commented Jan 29, 2020

Thanks for the patch!

@AlexWayfer AlexWayfer deleted the fix_warnings_from_ruby_2.7 branch January 29, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tycooon tycooon tycooon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWayfer @tycooon