Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec and doc for class methods #3

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

AlexWayfer
Copy link
Contributor

Without library changes: it seems working.

@coveralls
Copy link

coveralls commented Apr 19, 2018

Pull Request Test Coverage Report for Build 7

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 4: 0.0%
Covered Lines: 124
Relevant Lines: 124

💛 - Coveralls

@tycooon
Copy link
Owner

tycooon commented Apr 19, 2018

Well, that's working just because singleton classes work the same way as regular ones in Ruby, but I think that having this in Readme (and in specs) is nice.

@tycooon tycooon closed this Apr 19, 2018
@tycooon tycooon reopened this Apr 19, 2018
@tycooon tycooon merged commit 07610d2 into tycooon:master Apr 19, 2018
@AlexWayfer
Copy link
Contributor Author

Well, that's working just because singleton classes work the same way as regular ones in Ruby

Yes, you're right!

@AlexWayfer AlexWayfer deleted the add_tests_for_class_method branch April 19, 2018 16:40
@tycooon
Copy link
Owner

tycooon commented Apr 20, 2018

Thanks for the patch by the way 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants