Docs: Add instructions for how to get calendar URLs #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joestump I require a DCO (Signed-off-by) line in commit messages for contributions. Can you please do a squash of the commits in this PR and update the commit message to have on please? for example: git rebase -i HEAD~2
# follow the directions to squash
# The following will tack on your DCO if you haven't already added it
git commit --amend -s --no-edit
git push origin patch-1 --force |
tykeal
changed the title
|
You will also need to update the commit message to have a conventional commit message subject line. I've updated the PR title to reflect what I would expect. |
tykeal
pushed a commit
that referenced
this pull request
May 14, 2024
This is a re-implementation of PR #187 to pass tests. Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
Merged
tykeal
pushed a commit
that referenced
this pull request
May 14, 2024
This is a re-implementation of PR #187 to pass tests. Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
tykeal
pushed a commit
that referenced
this pull request
May 14, 2024
This is a re-implementation of PR #187 to pass tests. Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176 (I think?)