extra options #48
Merged
extra options #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tykeal
commented
Jan 20, 2022
tykeal
commented
- Feat: Allow integration to work without Keymaster
- Fix: Fix issues when validating no lock
- Feat: Allow Non-reservations to be stored
There has been a request to allow the integration to not depend on Keymaster. As we are not requiring a lock to actually be used, this makes sense. However, we will lose functionality that is planned for the future related to modifying checkin/checkout times of individual events if there is no door code slot available as the intent is to inform the integration of changes by way of modification to the in/out times of the assigned door code. Issue: #45 Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
When no lock is selected (the default) if there are form validation errors then the resulting new form will have validation errors related to the lock slot if the end-user doesn't reselect the '(none)' option, which was the original default. Issue: #46 Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
The community has requested to allow 'Blocked' and 'Not available' events to still be stored and reported because of various reasons. As such, we want to make this something that is optional (default to not storing). Issue: #47 Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.