Merge pull request #8 from bmonty/bmonty/bug-fix/issue-7

Bmonty/bug fix/issue 7
tylerdmace · Mar 14, 2015 · 55dca54 · 55dca54
2 parents 3de8173 + 2eaceda
commit 55dca54
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1,2 @@
+subnetter.sublime-workspace
+subnetter.sublime-project
diff --git a/subnetter.js b/subnetter.js
@@ -154,7 +154,7 @@
     var sub  = Subnetter.addressToDecimal(subnet_id);
     var mask = Subnetter.addressToDecimal(netmask);
 
-    if ((addr & mask) === sub){
+    if (((addr & mask) >>> 0) === sub){
       return 1;
     }
     else{

diff --git a/test/test.subnetter.js b/test/test.subnetter.js
@@ -41,4 +41,10 @@ describe('SubnetterJS', function() {
     expect(Subnetter.getNetwork('192.168.1.0', '255.255.255.0')).to.equal('192.168.1.0');
   });
 
+  it('can check if an IP is part of a subnet', function() {
+    expect(Subnetter.checkIPInSubnet('192.168.1.1', '192.168.1.0', '255.255.255.0'), 1);
+    expect(Subnetter.checkIPInSubnet('192.168.204.201', '192.168.204.0', '255.255.255.0'), 1);
+    expect(Subnetter.checkIPInSubnet('192.168.203.100', '192.168.204.0', '255.255.255.0') ,0);
+  })
+
 });
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		subnetter.sublime-workspace
		subnetter.sublime-project