Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https_kwargs -> http_kwargs, fix bug with http_kwargs #12

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Conversation

tylerjthomas9
Copy link
Owner

Renaming https_kwargs -> http_kwargs to match OpenAI.jl and PromptingTools.jl. Fix bug where http_kwargs were not properly passed to _request.

@svilupp
Copy link

svilupp commented Mar 26, 2024

Random question -are you manually registering your versions?

If yes, consider copying the tagbot workflow and using the JuliaRegistrator! It saves you a ton of time

@tylerjthomas9
Copy link
Owner Author

Random question -are you manually registering your versions?

Yes, I manually register on JuliaHub. I always have the tab open and ready to hit register whenever the checks go green, however I should probably register it with the bot so that others can see when it is triggered.

@tylerjthomas9 tylerjthomas9 merged commit 0749448 into main Mar 26, 2024
6 checks passed
@tylerjthomas9 tylerjthomas9 deleted the dev-tyler branch May 17, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants