This repository has been archived by the owner on Sep 5, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
TLS doesn't support connection TCPKeepAlive Option #85
Comments
To reproduce do something like this:
Then try and connect to port with a browser.
|
I can try and work up a PR if you're interested, but it seems relatively straightforward to fix. |
@yanfali Thanks for reporting the issue! 😄 If you could open a PR, that would be really awesome too! |
yanfali
pushed a commit
to awakesecurity/graceful
that referenced
this issue
Aug 14, 2016
Order matters when enabling TCP Keep Alives. Keep alives need to be configured before wrapping them with a TLS Listener. In the current implementation the TCP Keep Alive listener wraps after TLS is enabled and TLS Listener doesn't have methods to access the lower layer TCP behavior. 1. remove the TCP Keep Alive Listner from Serve 2. re-add it after creating a tcp Listener and before wrapping in TLS 3. update TLS unit tests to always specify TCPKeepAlive values to catch regressions.
yanfali
pushed a commit
to awakesecurity/graceful
that referenced
this issue
Aug 14, 2016
Order matters when enabling TCP Keep Alives. Keep alives need to be configured before wrapping them with a TLS Listener. In the current implementation the TCP Keep Alive listener wraps after TLS is enabled and TLS Listener doesn't have methods to access the lower layer TCP behavior. 1. remove the TCP Keep Alive Listener from Serve 2. re-add TCP Keep Alive after creating a tcp Listener but before wrapping in TLS 3. update TLS unit tests to always specify TCPKeepAlive values to catch regressions.
yanfali
pushed a commit
to awakesecurity/graceful
that referenced
this issue
Aug 14, 2016
Order matters when enabling TCP Keep Alives. Keep alives need to be configured before wrapping them with a TLS Listener. In the current implementation the TCP Keep Alive listener wraps after TLS is enabled and TLS Listener doesn't have methods to access the lower layer TCP behavior. 1. remove the TCP Keep Alive Listener from server.Serve 2. create a newTCPListener to server which returns wrapped instanced 3. update TLS unit tests to always specify TCPKeepAlive values to catch regressions.
@F21 hope this works for the project. |
yanfali
pushed a commit
to awakesecurity/graceful
that referenced
this issue
Aug 14, 2016
Order matters when enabling TCP Keep Alives. Keep alives need to be configured before wrapping them with a TLS Listener. In the current implementation the TCP Keep Alive listener wraps after TLS is enabled and TLS Listener doesn't have methods to access the lower layer TCP behavior. 1. remove the TCP Keep Alive Listener from server.Serve 2. create a newTCPListener() on server that returns keep alive wrapped instances on demand 3. update TLS unit tests to always specify TCPKeepAlive values to catch regressions.
F21
added a commit
that referenced
this issue
Aug 15, 2016
ISSUE #85: TCP Keep Alive cannot wrap TLS
Closed via #86 |
@F21 Any timeline when this is going to be released to gopkg.in? I'm using vendoring so I can switch back github, but if you're going to push a release I can wait. Thanks |
@yanfali Thanks for reminding me! I just pushed |
Awesome! Thank you. |
zjs
added a commit
to zjs/vic
that referenced
this issue
Sep 26, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
zjs
added a commit
to zjs/vic
that referenced
this issue
Sep 28, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
zjs
added a commit
to vmware/vic
that referenced
this issue
Sep 30, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
zjs
added a commit
to zjs/vic
that referenced
this issue
Oct 9, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
zjs
added a commit
to vmware/vic
that referenced
this issue
Oct 25, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
zjs
added a commit
to vmware/vic
that referenced
this issue
Oct 31, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
zjs
added a commit
to vmware/vic
that referenced
this issue
Nov 6, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
zjs
added a commit
to vmware/vic
that referenced
this issue
Nov 6, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
zjs
added a commit
to zjs/vic
that referenced
this issue
Nov 7, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
zjs
added a commit
to zjs/vic
that referenced
this issue
Nov 7, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
zjs
added a commit
to vmware/vic
that referenced
this issue
Nov 15, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
zjs
added a commit
to vmware/vic
that referenced
this issue
Nov 16, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
zjs
added a commit
to vmware/vic
that referenced
this issue
Nov 20, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
AngieCris
pushed a commit
to AngieCris/vic
that referenced
this issue
Nov 20, 2017
This was a mechanical change using the following commands: gvt delete github.com/tylerb/graceful gvt fetch -revision 4654dfbb6ad53cb5e27f37d99b02e16c1872fbbb \ https://github.com/tylerb/graceful This is needed to pick up the fix for tylerstillwater/graceful#85
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This issue on etcd explains the issue.
etcd-io/etcd#2185
The text was updated successfully, but these errors were encountered: