Resolve config from extends package #781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import SilentError from 'silent-error'; | ||
| import { GlintConfig } from './config.js'; | ||
| import { GlintConfigInput } from '@glint/core/config-types'; | ||
| import type * as TS from 'typescript'; | ||
|
|
||
| const require = createRequire(import.meta.url); | ||
| export const require = createRequire(import.meta.url); |
There was a problem hiding this comment.
why export this?
conventionally, we really only want to use createRequire in the file it's used in, since the resolution rules are specific to the import.meta.url
There was a problem hiding this comment.
ah, it's for mocking in tests.
can you add a block-comment with something like:
/**
* @private
*
* Only exported for testing purposes. Do not import.
*/| JSON.stringify({ | ||
| extends: '@package1/tsconfig.json', | ||
| glint: { | ||
| environment: '../local-env', |
There was a problem hiding this comment.
To be honest, I simply followed the example from the previous test which uses a predefined environment in the beforeEach
Definitely, I will create a PR against the main branch |
|
PR Created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve glint configuration when your tsconfig.json extends from a package, ex
path: tsconfig.json
{ "extends": "@package1" }path: node_modules/@package1/tsconfig.json
{ "glint": { "environment": ["ember-loose", "ember-template-imports"] } }Note: I'm uncertain if this is the correct branch to merge with. If it isn't, please let me know.