Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve
ManyToManyDescriptor
and fixModel.<manytomany>.through
typing #1805Improve
ManyToManyDescriptor
and fixModel.<manytomany>.through
typing #1805Changes from 5 commits
da86f3a
f1425aa
f1f53bb
a6cc98d
b87f9dc
866645a
e5462f1
d45a3db
968d4c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realised that the plugin needs to make the returned
ManyRelatedManager
here more accurate, so that it's possible to find custom queryset/manager methods.Quite surprised we're missing tests for that actually.
It probably would've been easiest if
ManyRelatedManager
was another type argument, but I don't think it can. Since it's not possible to pass any dynamically generated managers as type arguments (ref #1699).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've adjusted so that we imitate Django's behaviour by having the plugin create a manager class with
ManyRelatedManager
and the_To
model's default manager as bases.Ref: https://github.com/django/django/blob/46df3ab244e1688bd186f0bfbfea6a354097a910/django/db/models/fields/related_descriptors.py#L1032