Version 5.1.0 release #2374
Open
Version 5.1.0 release #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaeppe
reviewed
Sep 18, 2024
There was a problem hiding this comment.
I'm suspecting that releasing at this point will result in quite a bit of reports regarding annotate/alias
I've been meaning to dig in to some of the more "normal" usage but haven't gotten around to it yet
Perhaps it's for the better to just release and see what happens
Sorry, I am out of context. What is this about? |
|
I might be misremembering, but I think I had some additional case that would be good to cover in our tests for annotate. Think I had encountered some simple usage that was breaking. But I have to check if I wrote anything down or if it was from somewhere else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blindly following the instructions in Contributing.md. pre-commit passes, stubtest passes, I hope that means that this PR makes sense and there are no release blockers.
Version 5.0.4 broke with with Django 5.1 in one of the projects I'm working on due to the
check/conditionrename that was fixed in #2331 but not yet released.