Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypedDictType crash with mypy 1.12.x #2408

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

federicobond
Copy link
Contributor

In mypy 1.12, the constructor for TypedDictType added a new parameter for read-only fields, which was causing the plugin to crash.

Related issues

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry, it was me who added it. I had to proper do the plugin announcement and refactoring of this plugin, but I forgot about it :)

@sobolevn sobolevn merged commit c9c7290 into typeddjango:master Oct 16, 2024
38 checks passed
@federicobond federicobond deleted the mypy-1.12-support branch October 16, 2024 14:57
asottile-sentry pushed a commit to getsentry/sentry-forked-django-stubs that referenced this pull request Oct 22, 2024
asottile-sentry added a commit to getsentry/sentry-forked-django-stubs that referenced this pull request Oct 22, 2024
upstream PR typeddjango#2408

Co-authored-by: Federico Bond <federicobond@gmail.com>
@kingbuzzman
Copy link

When will this be released? Do we know when the next release is going to be?

@sobolevn
Copy link
Member

@flaeppe let's make a release :)

@kingbuzzman
Copy link

Please, I have a hack at the moment where i'm hardcoding mypy to <1.12.0 because of this issue.

@flaeppe flaeppe mentioned this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants