Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kill): should not wait too much to open a connection to ReplSet #813

Merged
merged 9 commits into from
Nov 13, 2023

Conversation

arthursimas1
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #813 (624ad39) into master (fefa869) will decrease coverage by 0.06%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   91.14%   91.09%   -0.06%     
==========================================
  Files          15       15              
  Lines        1965     1965              
  Branches      494      494              
==========================================
- Hits         1791     1790       -1     
- Misses        165      166       +1     
  Partials        9        9              
Files Coverage Δ
...ngodb-memory-server-core/src/util/MongoInstance.ts 98.15% <ø> (-0.47%) ⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the connection spy is actually checked, this PR would be good

@arthursimas1 arthursimas1 requested a review from hasezoey October 13, 2023 05:30
Copy link
Member

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just some semantics (some of which i wrongly suggested previously)

Copy link

Marking the PR as stale, it will be closed in 7 days if no more activity is seen

@github-actions github-actions bot added the stale This Issue is outdated and will likely be closed if no further comments are given label Nov 13, 2023
@hasezoey
Copy link
Member

as this PR had no more activity, but the changes are still good, i will modify it myself and then merge

@hasezoey hasezoey changed the base branch from master to beta November 13, 2023 13:05
@hasezoey hasezoey merged commit 668b42a into typegoose:beta Nov 13, 2023
8 of 9 checks passed
Copy link

Copy link

@github-actions github-actions bot added the released Pull Request released | Issue is fixed label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta released Pull Request released | Issue is fixed stale This Issue is outdated and will likely be closed if no further comments are given
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants