Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timed out tests doesn't fail the sbt task #3503

Closed
durban opened this issue Mar 20, 2023 · 5 comments · Fixed by #3551
Closed

Timed out tests doesn't fail the sbt task #3503

durban opened this issue Mar 20, 2023 · 5 comments · Fixed by #3551

Comments

@durban
Copy link
Contributor

durban commented Mar 20, 2023

This might be a specs2 thing, but it seems unlikely that it's intentional.

  • One example is here
  • Another one here (the CI execution was cancelled, not failed; I don't know what and why cancelled it, might it be related?):
[info] DrainBatchSpec
[info] Batch draining should
[info]   o work correctly in the presence of concurrent stealers
[info] timeout exception
@armanbilge
Copy link
Member

  • CI execution was cancelled, not failed; I don't know what and why cancelled

We have a 1 hour time limit on CI to prevent hanging. Maybe it's not sufficient?

timeout-minutes: 60

@durban
Copy link
Contributor Author

durban commented Mar 20, 2023

Hm, okay, that's what cancelled it :-) There might be a real problem there (most JVM runs finished in around 15 minutes, so 60 should be plenty), unclear if related to the timed out specs2 test...

@durban
Copy link
Contributor Author

durban commented Mar 20, 2023

It might be intentional, but I still don't understand why they make a timeout a skipped test:
https://github.com/etorreborre/specs2/blob/SPECS2-4.19.2/core/shared/src/main/scala/org/specs2/specification/core/Execution.scala#L156-L160

Also, there is this here:
https://github.com/typelevel/cats-effect/blob/series/3.x/tests/shared/src/test/scala/cats/effect/Runners.scala#L103-L117
So it might be an unintentional interaction...

@armanbilge
Copy link
Member

It might be intentional, but I still don't understand why they make a timeout a skipped test:

Also, there is this commit: etorreborre/specs2@2476639 🤔

@durban
Copy link
Contributor Author

durban commented Apr 24, 2023

Should be fixed by #3551.

@durban durban closed this as completed Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants