Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutex cancelled acquire #3549

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Conversation

durban
Copy link
Contributor

@durban durban commented Apr 24, 2023

Fix Async mutex acquire to be cancellation-safe.

@armanbilge
Copy link
Member

armanbilge commented Apr 24, 2023

Unfortunately this doesn't seem to have fixed the Skunk issue 😕 tried it in armanbilge/skunk@7a2ab6a.

@armanbilge
Copy link
Member

The test you added is good but unfortunately it's affected by #3503 😕

@armanbilge
Copy link
Member

Is this cancelation safe? Can the async which created this waiter be canceled before it is invoked?

var waiter = waiters.take()
while (waiter eq null) waiter = waiters.take()
waiter(RightTrue) // pass the buck

@durban
Copy link
Contributor Author

durban commented Apr 24, 2023

Yeah, I think that's the same problem as the one was with Queue. Probably could be fixed the same way...

@armanbilge
Copy link
Member

Oh right. How was that one fixed? 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants