surround and surroundK added to Resource #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkowalcze
commented
Oct 29, 2020
pkowalcze
commented
Oct 29, 2020
kubukoz
approved these changes
Oct 30, 2020
SystemFw
reviewed
Nov 4, 2020
| @@ -417,6 +417,20 @@ sealed abstract class Resource[+F[_], +A] { | |||
| */ | |||
|
|
|||
| private[effect] def invariant: Resource.InvariantResource[F0, A] | |||
|
|
|||
| /** | |||
| * Wraps an effect in a usage and ignores the value produced by resource. | |||
There was a problem hiding this comment.
I would change this scaladoc to something like:
acquires the resource, runs `gb`, and closes the resource once `gb` terminates, fails or gets interrupted
There was a problem hiding this comment.
Sounds good 👍 And for surroundK would the following be ok?
Creates a FunctionK that can run `gb` within a resource, which is then closed once `gb` terminates, fails or gets interrupted
There was a problem hiding this comment.
Updated the scaladoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #1338 - added
surroundandsurroundKmethods onResource