On jvm IOApp clean exit, optionally print non-daemon threads #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpilquist
requested changes
Nov 2, 2020
core/jvm/src/main/scala/cats/effect/internals/IOAppPlatform.scala
Outdated
Show resolved
Hide resolved
core/jvm/src/main/scala/cats/effect/internals/IOAppPlatform.scala
Outdated
Show resolved
Hide resolved
core/jvm/src/main/scala/cats/effect/internals/IOAppPlatform.scala
Outdated
Show resolved
Hide resolved
core/jvm/src/main/scala/cats/effect/internals/IOAppPlatform.scala
Outdated
Show resolved
Hide resolved
|
@mpilquist Thanks for the feedback. I'll try to get that cleaned up this weekend. Feel free to poke me if I don't ;) |
Daenyth
force-pushed
the
log-nondaemon
branch
2 times, most recently
from
222d669 to
ab94ad2
Compare
mpilquist
approved these changes
Nov 12, 2020
Debugging when a jvm is being held open due to non-daemon threads is a royal pain. Try to help users here (who might not even know this can happen) by giving the option to debug, which we can put into a FAQ entry I opted for making it configurable here since this isn't a problem for most people, and there's no reason to slow down the shutdown for it unless debugging
Daenyth
force-pushed
the
log-nondaemon
branch
from
ab94ad2 to
c8bfc27
Compare
|
The re-push was just the fix the "missing headers" CI failure. No changes aside from that |
Meant to do that from the start; accidentally did 1 sec
https://github.com/typelevel/cats-effect/runs/1393002433#step:14:40 |
|
I fixed the collections-compat part. I think this should be ready for merge now. I don't think it's a blocker, but I'm wondering how I could possibly write a unit test for this kind of behavior, though. It seems very hard to do. Any suggestions? |
|
Merged; thank you! I don't think it needs unit testing. Probably possible, definitely annoying, limited value. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging when a jvm is being held open due to non-daemon threads is a royal
pain. Try to help users here (who might not even know this can happen) by
giving the option to debug, which we can put into a FAQ entry
I opted for making it configurable here so that folks who know their app is fine can disable it if they want to avoid us creating a Daemon thread near shutdown time.