Use platform-dependent implementation of Clock.realTime #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeykolbasov
force-pushed
the
instant-clock
branch
2 times, most recently
from
dcec865 to
de49624
Compare
sergeykolbasov
force-pushed
the
instant-clock
branch
from
de49624 to
71df136
Compare
|
@djspiewak Hello, any thoughts on this? |
|
Sorry! This somehow fell off my radar in the shuffle. This looks very good! Would you be interested in looking into bringing these improvements to the |
|
No problem. Sure can do for 3.x, although last time I checked there was no actual implementation of clocks there. Is it supposed to be the same? |
|
Clock is defined as a typeclass, and the implementation is in IO and SyncIO (in CE3). 😃 Just a reorganization, not a removal. |
brendanmaguire
added a commit
to brendanmaguire/cats-effect
that referenced
this pull request
Oct 16, 2021
…the JVM * Use `java.time.Instant` to provide microsecond precision for `nowMicros` * Use `nowMicros` instead of `nowMillis` to determine the real time This is a follow up to typelevel#1461
brendanmaguire
added a commit
to brendanmaguire/cats-effect
that referenced
this pull request
Mar 20, 2022
…the JVM * Use `java.time.Instant` to provide microsecond precision for `nowMicros` * Use `nowMicros` instead of `nowMillis` to determine the real time * Provide default implementation of `Scheduler#nowMicros` This is a follow up to typelevel#1461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1460