Circular buffer for parked worker threads and removed lock #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
approved these changes
Dec 4, 2020
Comment on lines
+53
to
+62
| while ({ | ||
| hd = head.get() | ||
| tl = tail.get() | ||
|
|
||
| if (hd == tl) | ||
| return null | ||
|
|
||
| idx = hd | ||
| !head.compareAndSet(hd, hd + 1) | ||
| }) () |
There was a problem hiding this comment.
Officially the most hilarious while loop formulation I've ever seen. I know it's just encoding do/while, but still.
There was a problem hiding this comment.
This is the recommended way to do it in the Dotty docs, just fyi. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corroborated by benchmark improvements
WorkStealingBenchmark.async before:
10.660 +- 0.529WorkStealingBenchmark.async after:
11.078 +- 0.218