-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement UUIDGen capability trait. #1772
Merged
Merged
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* | ||
* Copyright 2020-2021 Typelevel | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package cats.effect.std | ||
|
||
import cats.effect.kernel.Sync | ||
import cats.implicits._ | ||
import java.util.UUID | ||
|
||
/** | ||
* A purely functional UUID Generator | ||
*/ | ||
trait UUIDGen[F[_]] { | ||
|
||
/** | ||
* Generates a UUID in a pseudorandom manner. | ||
* @return randomly generated UUID | ||
*/ | ||
def randomUUID: F[UUID] | ||
|
||
/** | ||
* Generates a UUID in a pseudorandom manner and returns String representation of this UUID. | ||
* @return randomly generated UUID string | ||
*/ | ||
def randomString: F[String] | ||
} | ||
|
||
object UUIDGen { | ||
def apply[F[_]](implicit ev: UUIDGen[F]): UUIDGen[F] = ev | ||
|
||
implicit def fromSync[F[_]: Sync]: UUIDGen[F] = new UUIDGen[F] { | ||
|
||
override def randomUUID: F[UUID] = Sync[F].delay(UUID.randomUUID()) | ||
override def randomString: F[String] = randomUUID.map(_.toString) | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we also add this to the companion? def randomString[F[_]: Functor: UUIDGen]: F[String] = randomUUID[F].map(_.toString) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, sounds reasonable. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant that the trait would have only
def randomUUID: F[UUID]
.While
randomString
would be a method on the object.Like:
Or we can just forget about it at all :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, done!