Try waking up a WorkerThread before spawning a HelperThread #1928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, any
scala.concurrent.blocking
operation is handled too paranoiacally, with aHelperThread
being spawned almost every time and the local queue of the blocked worker thread completely drained. This is not ideal for the situations where there are blocking operations which occur infrequently. In those situations, it is better to try to wake up another worker thread which would be able to steal the fibers of the blocked thread. That way, no new thread needs to be spawned, which is much faster and safer. If the blocking does propagate to other worker threads, or if a worker thread could not be woken up due to any reason, this degrades to the old implementation where aHelperThread
is spawned in anticipation.