Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discord badge #1951

Merged
merged 2 commits into from
May 9, 2021
Merged

Add discord badge #1951

merged 2 commits into from
May 9, 2021

Conversation

paualarco
Copy link
Contributor

@paualarco paualarco commented May 9, 2021

It might be a good idea to link people to Discord now that Typelevel has its own server, the way the badge is created is by the server id 632277896739946517, see the result:
Screen Shot 2021-05-09 at 17 59 39

README.md Outdated
Comment on lines 3 to 4
[![Gitter](https://img.shields.io/gitter/room/typelevel/cats-effect.svg)](https://gitter.im/typelevel/cats-effect) [![Latest version](https://index.scala-lang.org/typelevel/cats-effect/cats-effect/latest.svg?color=orange)](https://index.scala-lang.org/typelevel/cats-effect/cats-effect)
[![Discord](https://img.shields.io/discord/632277896739946517.svg?label=&logo=discord&logoColor=ffffff&color=404244&labelColor=6A7EC2)](https://discord.gg/vpEv3HJ)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually go a step further and remove Gitter altogether!

Suggested change
[![Gitter](https://img.shields.io/gitter/room/typelevel/cats-effect.svg)](https://gitter.im/typelevel/cats-effect) [![Latest version](https://index.scala-lang.org/typelevel/cats-effect/cats-effect/latest.svg?color=orange)](https://index.scala-lang.org/typelevel/cats-effect/cats-effect)
[![Discord](https://img.shields.io/discord/632277896739946517.svg?label=&logo=discord&logoColor=ffffff&color=404244&labelColor=6A7EC2)](https://discord.gg/vpEv3HJ)
[![Discord](https://img.shields.io/discord/632277896739946517.svg?label=&logo=discord&logoColor=ffffff&color=404244&labelColor=6A7EC2)](https://discord.gg/vpEv3HJ) [![Latest version](https://index.scala-lang.org/typelevel/cats-effect/cats-effect/latest.svg?color=orange)](https://index.scala-lang.org/typelevel/cats-effect/cats-effect)

Also I didn't check; I assume this is a non-expiring direct link to the #cats-effect channel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not posible to link directly into a specific channel in Discord, it will redirect to the main Typelevel server and from there the user will have to go the the channel of its interest.

Also I believe this is a non expiring link, as I mentioned this is using the serverId, which should not change :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will redirect to the main Typelevel server

Ah interesting! This must be a server setting, perhaps related to the CoC intercept stuff that the server is doing. I know for a fact that it's possible to link to specific channels in Discord invites, but perhaps that just doesn't work in our case. Either way, nice. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I think it is possible, currently the link is incorrect as I just copy pasted it from shields.io.
Sorry abt that, let me address it...

@djspiewak djspiewak merged commit aefc1b4 into typelevel:series/3.x May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants