-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Scaladoc example compile and modernize it #2083
Conversation
I like this. Should we also maybe add the required imports at the beginning of the code block? That way the examples can immediately be copy/pasted. |
@vasilmkd I've thought about that too, but I wasn't sure. Since you're thinking the same, then I'll add them. It certainly causes no issues. |
@igstan Check the output in the GitHub actions, you can see some small things that you've missed that you can fix. 😄 |
@vasilmkd oops, yes 😅 Fixing now. |
No worries, I'm pretty sure you can run |
I've amended the commit with a fix for the CI issue, plus the extra imports needed to run the example. This time I ran |
* `release` takes the allocated resource as a param * Use IO.println * Use Cats Effect's `Random`
Looks great. |
Thank you, both! |
I'm just reading through the source code of the library so I'm fixing such issues as I bump into them. In this case:
release
takes the allocated resource as a paramIO.println
Random