Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cats Effect 3 tracing docs #2128

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Cats Effect 3 tracing docs #2128

merged 3 commits into from
Jul 19, 2021

Conversation

vasilmkd
Copy link
Member

No description provided.

djspiewak
djspiewak requested changes Jul 18, 2021
View reviewed changes
Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great! I made a few suggestions along the way to try to make it more ever-green (i.e. just as relevant to a reader years from now as it is today). Also not entirely sure to do with the section in the middle, but we can work on it.

docs/tracing.md Outdated Show resolved Hide resolved
docs/tracing.md Outdated Show resolved Hide resolved
docs/tracing.md Outdated Show resolved Hide resolved
docs/tracing.md Outdated Show resolved Hide resolved
docs/tracing.md Outdated Show resolved Hide resolved
docs/tracing.md Outdated Show resolved Hide resolved
docs/tracing.md Outdated Show resolved Hide resolved
docs/tracing.md Outdated Show resolved Hide resolved
docs/tracing.md Outdated Show resolved Hide resolved
@vasilmkd
Copy link
Member Author

I incorporated your changes in a single commit and reformatted the page.

@vasilmkd
Copy link
Member Author

vasilmkd commented Jul 18, 2021 •
edited
Loading

I don't mind taking the middle part out and dropping it in the release notes.

@vasilmkd vasilmkd requested a review from djspiewak July 18, 2021 20:45
@djspiewak
Copy link
Member

Eh, let's keep it :-D

@djspiewak djspiewak merged commit a867792 into typelevel:series/3.x Jul 19, 2021
@vasilmkd vasilmkd deleted the tracing-docs branch July 19, 2021 14:56
@i10416 i10416 mentioned this pull request Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak Awaiting requested review from djspiewak

Assignees
No one assigned
Labels
📚 docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasilmkd @djspiewak