More scaladoc #2132
Merged
More scaladoc #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you are making more changes, tag me as a reviewer when you're done and I'll take a look. 😄 |
|
I'll take a look later tonight. |
vasilmkd
reviewed
Jul 19, 2021
| * {{{ | ||
| * IO.println("Hello, World!").foreverM // continues printing forever | ||
| * }}} | ||
| */ | ||
| def foreverM: IO[Nothing] = Monad[IO].foreverM[A, Nothing](this) |
There was a problem hiding this comment.
Does it matter if we change this to IO.asyncForIO.foreverM[A, Nothing](this)?
There was a problem hiding this comment.
It's probably slightly faster to do so in fact. Very slightly.
| @@ -20,16 +20,193 @@ import scala.concurrent.{blocking, CancellationException} | |||
|
|
|||
| import java.util.concurrent.CountDownLatch | |||
|
|
|||
| /** | |||
Co-authored-by: Vasil Vasilev <vasil@vasilev.io>
vasilmkd
approved these changes
Jul 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still lots of stuff to do.