Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust tracing to use IORuntimeConfig #2147

Merged
merged 6 commits into from
Jul 24, 2021
Merged

Adjust tracing to use IORuntimeConfig #2147

merged 6 commits into from
Jul 24, 2021

Conversation

djspiewak
Copy link
Member

Fixes #2144

vasilmkd
vasilmkd reviewed Jul 24, 2021
View reviewed changes
Copy link
Member

@vasilmkd vasilmkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes to the names of the constants.

I guess this still needs the constructor/copy shenaningans for Scala.js.

core/jvm/src/main/java/cats/effect/tracing/TracingConstants.java Show resolved Hide resolved
core/shared/src/main/scala/cats/effect/unsafe/IORuntimeConfig.scala Show resolved Hide resolved
core/shared/src/main/scala/cats/effect/unsafe/IORuntimeConfig.scala Outdated Show resolved Hide resolved
@djspiewak djspiewak marked this pull request as ready for review July 24, 2021 22:08
@djspiewak djspiewak added this to the 3.2.0 milestone Jul 24, 2021
vasilmkd
vasilmkd reviewed Jul 24, 2021
View reviewed changes
core/jvm/src/main/scala/cats/effect/unsafe/IORuntimeConfigCompanionPlatform.scala
protected final val Default: IORuntimeConfig = {
val cancelationCheckThreshold =
System.getProperty("cats.effect.cancelation.check.threshold", "512").toInt
Try(System.getProperty("cats.effect.cancelation.check.threshold").toInt).getOrElse(512)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My favorite stdlib monad.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"monad"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly.

@vasilmkd vasilmkd merged commit 5fb8e10 into typelevel:series/3.x Jul 24, 2021
armanbilge added a commit to armanbilge/schrodinger that referenced this pull request Jan 14, 2022
@armanbilge
scala.math -> java.lang.Math
a4f9592 
TIL typelevel/cats-effect#2147 (comment)
@bastewart bastewart mentioned this pull request Jan 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasilmkd vasilmkd vasilmkd approved these changes

Assignees

@vasilmkd vasilmkd

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Add tracing configuration to IORuntimeConfig
2 participants
@djspiewak @vasilmkd