-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check WorkerThread
ownership before scheduling
#2254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's another run:
|
djspiewak
requested changes
Aug 22, 2021
core/jvm/src/main/scala/cats/effect/unsafe/WorkStealingThreadPool.scala
Outdated
Show resolved
Hide resolved
core/jvm/src/main/scala/cats/effect/unsafe/WorkStealingThreadPool.scala
Outdated
Show resolved
Hide resolved
A new run of the scheduling benchmark:
|
djspiewak
requested changes
Aug 22, 2021
core/jvm/src/main/scala/cats/effect/unsafe/WorkStealingThreadPool.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Spiewak <djspiewak@gmail.com>
Another run, but thermal throttling might have kicked in. The second fork was down in terms of the score.
|
djspiewak
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the interleaving between two instances of
WorkStealingThreadPool
. I did not have a chance to test the performance impact thoroughly, but in the quick benchmark run I did, the new code was faster, which, I'm not sure whether to trust. I will repeat the run when I have the time.series/3.x
:This PR
: