Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PQueue FIFO priority ties #2309

Merged
merged 3 commits into from
Sep 6, 2021
Merged

Conversation

SystemFw
Copy link
Contributor

@SystemFw SystemFw commented Sep 5, 2021

See #2298

Copy link
Member

@vasilmkd vasilmkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with pending formatting and a CI run. 😄

@vasilmkd
Copy link
Member

vasilmkd commented Sep 5, 2021

A general project management question, does this PR essentially undo the work that started the series/3.2.x branch (minus the new comments in this PR)?

@SystemFw
Copy link
Contributor Author

SystemFw commented Sep 6, 2021

does this PR essentially undo the work that started the series/3.2.x branch

Yes, and actually I wasn't fully sure what the best way of going about it was. I reverted changes and 3.2.x, but not 100% confident that's the way to go

@TimWSpence
Copy link
Member

LGTM! 👍

@djspiewak djspiewak merged commit af2963d into series/3.2.x Sep 6, 2021
@armanbilge armanbilge deleted the revert-pqueue-ties branch July 11, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants