Attempt to detect host environments (like unforked sbt) #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
Jan 1, 2022
vasilmkd
approved these changes
Jan 2, 2022
LeifW
reviewed
Nov 22, 2024
| @@ -200,6 +200,9 @@ trait IOApp { | |||
| def run(args: List[String]): IO[ExitCode] | |||
|
|
|||
| final def main(args: Array[String]): Unit = { | |||
| // checked in openjdk 8-17; this attempts to detect when we're running under artificial environments, like sbt | |||
There was a problem hiding this comment.
Does this comment mean that this has been tested on those Java versions? I'm on Java 23, and Thread.currentThread().getId() returns 1 - though that .getId() got deprecated in Java 19, because:
This method is not final and may be overridden to return a value that is not the thread ID. Use threadId() instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than printing and calling
System.exit, we justthrowwhenever we're not forked. The detection here actually seems robust enough to lean on, particularly since the degradation path is fine. This also has the pleasing side effect of integrating better with sbt'slastcommand.Fixes #2706