Run blocking code on the compute pool more carefully #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before you merge, I'm running benchmarks just to check for regressions. |
|
Benchmark runs:
Benchmark (size) Mode Cnt Score Error Units
BlockingBenchmark.blockThenCede 10000 thrpt 20 6.229 ± 0.299 ops/s
BlockingBenchmark.coarse 10000 thrpt 20 3565.953 ± 105.111 ops/s
BlockingBenchmark.fine 10000 thrpt 20 758.839 ± 19.670 ops/s
BlockingBenchmark.nested 10000 thrpt 20 729.449 ± 12.753 ops/s
Benchmark (size) Mode Cnt Score Error Units
BlockingBenchmark.blockThenCede 10000 thrpt 20 6.481 ± 0.274 ops/s
BlockingBenchmark.coarse 10000 thrpt 20 3481.849 ± 111.972 ops/s
BlockingBenchmark.fine 10000 thrpt 20 771.115 ± 7.107 ops/s
BlockingBenchmark.nested 10000 thrpt 20 752.231 ± 8.088 ops/sNo issues. We can merge. |
|
Excellent work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only run blocking code if the worker thread matches the compute runtime.