Implemented unhandled error reporting for orphan fibers #2868
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enriches
CallbackStack
with the ability to report when no callbacks were invoked. Note that this isn't entirely perfect, since a fiber whichjoin
s and is latercancel
ed within thejoin
will empty out its callback, but thejoin
ed fiber may finish with an error at the exact same moment. If this happens and thejoin
ing fiber is the only fiber, the error would have been side-channeled but might end up being missed. I think this is a fairly reasonable tradeoff though, at least for the moment. The alternative is that we force a memory barrier in this case, which I think is a bit too much deoptimization for this edge case.Closes #2842