Fix leaking array ref in Random
#2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent catch! Should we be targeting this at |
|
Yes, shall I change the target branch? |
|
Yep, you'll also probably have to rebase and force-push :) |
catostrophe
force-pushed
the
fix/random-reference-leak
branch
from
8eb3255
to
f1ac8d5
Compare
|
Done. The build has failed on some unrelated (flaky?) js test. Could you restart? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in
cats.effect.std.Randomimpl. In some casesnextBytesreturns a ref to the same array. The bug is demonstrated in the newly added tests.N.B. I changed the impl of both
ThreadLocalRandomandScalaRandom, although the bug appears only in the former.ScalaRandomworks fine due to a delay in a preliminaryflatMapbefore array creation. But I made the code identical toThreadLocalRandomas to prevent the wrong pattern from being blindly copied somewhere else.