-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fromCompletableFuture
cancelation leak
#3425
Merged
djspiewak
merged 14 commits into
typelevel:series/3.4.x
from
armanbilge:bug/completable-future-cancellation-leak
Feb 17, 2023
Merged
Fix fromCompletableFuture
cancelation leak
#3425
djspiewak
merged 14 commits into
typelevel:series/3.4.x
from
armanbilge:bug/completable-future-cancellation-leak
Feb 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we could observe cancelation on the `flatMap` boundary before we register the finalizer
…g/completable-future-cancellation-leak
Damn it. You broke it, you bought it 😩 |
This reverts commit b819783.
Welp. We must have some global fiber monitor state somewhere, that persists across isolated runtimes ... Edit oh lol cats-effect/core/jvm-native/src/main/scala/cats/effect/unsafe/FiberMonitor.scala Lines 219 to 228 in 204fca2
|
This reverts commit 8c292a6.
djspiewak
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I inadvertently took over @TimWSpence's PR #3417 😅