Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow that the renamed blocker thread is terminated #3484

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Allow that the renamed blocker thread is terminated #3484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions tests/jvm/src/test/scala/cats/effect/unsafe/WorkerThreadNameSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,13 @@ class WorkerThreadNameSpec extends BaseSpec with TestInstances {
computeThreadName must startWith("io-compute")
// Check that entering a blocking region changes the name
blockerThreadName must startWith("io-blocker")
// Check that the same thread is renamed again when it is readded to the compute pool
val resetBlockerThread = resetComputeThreads.collectFirst {
case (name, `blockerThreadId`) => name
// Check that the same thread is renamed again if it is readded to the compute pool
resetComputeThreads.map {
case (name, `blockerThreadId`) => {
name must startWith("io-compute").setMessage("blocker thread name was not reset")
}
case _ => ok
}
resetBlockerThread must beSome[String].setMessage(
"blocker thread not found after reset")
resetBlockerThread must beSome((_: String).startsWith("io-compute"))
.setMessage("blocker thread name was not reset")
}
}
}
Expand Down