Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flush to print functions in std.Console #3498

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Add flush to print functions in std.Console #3498

merged 1 commit into from
Mar 22, 2023

Conversation

zetashift
Copy link
Contributor

This time picked off from the right branch!

From discord:

I think we should probably just add it on each call. That's kind of what people intuitively expect anyway. If someone wants more control over buffering, they should use Fs2. Console is meant for quick-and-dirty things

@armanbilge armanbilge linked an issue Mar 15, 2023 that may be closed by this pull request
CE3 IOApp finishes early before all finalizers #1736
Closed
djspiewak
djspiewak approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@djspiewak djspiewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@djspiewak djspiewak merged commit b959325 into typelevel:series/3.4.x Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak djspiewak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CE3 IOApp finishes early before all finalizers
2 participants
@zetashift @djspiewak