Make blockedThreadDetectionEnabled configurable via a system property #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
Apr 26, 2023
Comment on lines
256
to
260
| protected def blockedThreadDetectionEnabled: Boolean = | ||
| Option(System.getProperty("cats.effect.detectBlockedThreads")).map(_.toLowerCase()) match { | ||
| case Some(value) => value.equalsIgnoreCase("true") | ||
| case None => false // default to disabled | ||
| } |
There was a problem hiding this comment.
I wonder if we simplify this with java.lang.Boolean.getBoolean method.
https://docs.oracle.com/javase/8/docs/api/java/lang/Boolean.html#getBoolean-java.lang.String-
There was a problem hiding this comment.
It looks like using getBoolean would indeed be simpler. Updating the branch.
armanbilge
reviewed
Apr 26, 2023
| @@ -25,6 +25,7 @@ This can be done for example with the [EnvironmentPlugin for Webpack](https://we | |||
|
|
|||
| | System Property (JVM) / ENV Variable (JS) | Value (default) | Description | | |||
| |---------------------------------------------------------------------------------------------------|--------------------|-----------------------------------------------------------------------------------------------------------------------------------| | |||
| | `cats.effect.detectBlockedThreads` <br/> N/A | `Boolean` (`false`) | Whether or not we should detect blocked threads. | | |||
armanbilge
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3561.