Remove workaround for Scala3 in Supervisor
#3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
May 28, 2023
build.sbt
Outdated
Comment on lines
951
to
952
| ProblemFilters.exclude[DirectMissingMethodProblem]( | ||
| "cats.effect.std.Supervisor.apply$default$2") |
There was a problem hiding this comment.
This filter is highly unfortunate 🤔 if we ever add default parameters to the public API in the future then it will mask bincompat issues there.
Is it possible that this filter is needed only for Scala 3?
There was a problem hiding this comment.
Yep, it makes sense only for Scala3, I will fix it
There was a problem hiding this comment.
Also, sorry for stealing your fruit 😄
danicheg
force-pushed
the
rm-dotty-workaround
branch
from
dca0da7 to
f69d693
Compare
|
Smth strange is going on with CI 😞 @armanbilge could you please trigger CI run once again? |
|
Argh, I've done smth stupid. Sorry! |
danicheg
force-pushed
the
rm-dotty-workaround
branch
from
f69d693 to
cf5f7af
Compare
armanbilge
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to scala/scala3#15546.