Optimize liveTraces() on JS
#3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durban
previously approved these changes
Jul 1, 2023
| "iterate over contents in foreach" in { | ||
| forAll { (stuff: List[Option[Int]]) => | ||
| val queue = new JSArrayQueue[Int] | ||
| val shadow = new Queue[Int] |
There was a problem hiding this comment.
It's good to see I'm not the only one who tends to call these things "shadows" :-) (Although I don't remember where I've got the idea from.)
| } | ||
| } | ||
|
|
||
| true must beTrue |
There was a problem hiding this comment.
oh lol good call
Suggested change
| true must beTrue | |
| ok |
durban
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a silly one: we already have a queue of fibers, so it's unnecessary to add/remove them from a separate fiber bag for monitoring. We can just directly iterate over the queue.