Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Deferred#complete type #3740

Merged
merged 1 commit into from
Jul 11, 2023
Merged

update Deferred#complete type #3740

merged 1 commit into from
Jul 11, 2023

Conversation

ag91
Copy link
Contributor

@ag91 ag91 commented Jul 9, 2023

Fixes #3720

@durban
Copy link
Contributor

durban commented Jul 11, 2023

Thanks! I think this should go intoseries/3.5.x instead. Could you retarget the PR?

@ag91 ag91 changed the base branch from series/3.x to series/3.5.x July 11, 2023 12:10
@ag91
Copy link
Contributor Author

ag91 commented Jul 11, 2023

just rebasing now, I will ping when this is ready

@ag91
Copy link
Contributor Author

ag91 commented Jul 11, 2023

right I did rebase. Note though: also the 3.x series has the problem in the docs.
(I am assuming you suggested to move the change to the 3.5.x because it is more pragmatic to be correct on the most recent version: did I get you right?)

@armanbilge
Copy link
Member

Yes, that's right. We fix in 3.5.x because that's the current published series, and we regularly merge changes from 3.5.x into 3.x.

Further reading:
https://github.com/typelevel/cats-effect/blob/series/3.x/CONTRIBUTING.md#process

durban
durban approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@durban durban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@durban durban merged commit 0b3bbe9 into typelevel:series/3.5.x Jul 11, 2023
@durban durban mentioned this pull request Jul 13, 2023
Closed
@armanbilge armanbilge changed the title update Deferred.complete type update Deferred#complete type Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durban durban durban approved these changes

Assignees
No one assigned
Labels
📚 docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect signature in documentation
3 participants
@ag91 @durban @armanbilge