Print warning when we detect a non-main-thread main #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daenyth
commented
Aug 4, 2023
| * isn't the main process thread. This condition can happen when we are running inside of an | ||
| * `sbt run` with `fork := false` | ||
| */ | ||
| private def onNonMainThreadDetected(): Unit = { |
There was a problem hiding this comment.
This can probably become protected in the next API break, though honestly I'm skeptical that it's valuable to expose at all
There was a problem hiding this comment.
Yeah I'd rather not expose an API like this in IOApp. :-) Better to keep it private.
This should help people not run facefirst into sbt/sbt#6242 It's a frequent question for new users
Daenyth
force-pushed
the
sbt-fork-damnit
branch
from
94a7b60
to
d42975a
Compare
armanbilge
reviewed
Aug 5, 2023
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
djspiewak
approved these changes
Sep 2, 2023
| * isn't the main process thread. This condition can happen when we are running inside of an | ||
| * `sbt run` with `fork := false` | ||
| */ | ||
| private def onNonMainThreadDetected(): Unit = { |
There was a problem hiding this comment.
Yeah I'd rather not expose an API like this in IOApp. :-) Better to keep it private.
djspiewak
requested changes
Sep 2, 2023
Co-authored-by: Daniel Spiewak <djspiewak@gmail.com>
djspiewak
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help people not run facefirst into sbt/sbt#6242
It's a frequent question for new users