Fix Hotswap#get being blocked by Hotswap#swap
#3800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
Aug 30, 2023
…ther than the entire lock and swapFinalizer call
armanbilge
reviewed
Aug 30, 2023
armanbilge
reviewed
Aug 30, 2023
armanbilge
reviewed
Sep 2, 2023
armanbilge
reviewed
Sep 2, 2023
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
armanbilge
changed the title
Hotswap#get being blocked by Hotswap#swap
armanbilge
previously approved these changes
Sep 14, 2023
Thanks! Didn't want this PR to get lost to the sands of time. Thank you for those tweaks! That use of |
durban
previously approved these changes
Sep 18, 2023
Co-authored-by: Daniel Urban <urban.dani@gmail.com>
forkedcancel
dismissed stale reviews from durban and armanbilge
via
854e2b8
armanbilge
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotswap#swapcurrently acquires all permits for its Semaphore during allocation of thenextResource, blockingHotswap#getuntil the new Resource has been instantiated. In many use cases this will not be perceptible but if the Resource has a long initialization time, any calls togetwill block until the new Resource is ready... effectively undermining the very premise of Hotswap.