Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warnOnNonMainThreadDetected configuration to IOApp #3815

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Add warnOnNonMainThreadDetected configuration to IOApp #3815

merged 7 commits into from
Oct 2, 2023

Conversation

diogocanut
Copy link
Contributor

Solves #3806

@armanbilge
Copy link
Member

Thanks, but this is missing the other changes from #3814 where you actually use warnOnNonMainThreadDetected :) everything you did there was perfect, we just need to target it at this branch.

@armanbilge
Copy link
Member

Oh of course 🤦 that's why you couldn't make the change, because we didn't merge series/3.5.x branch into series/3.x branch yet. Sorry I forgot about that. We should wait until that happens, then this PR makes sense.

@armanbilge armanbilge marked this pull request as draft September 23, 2023 20:17
@armanbilge
Copy link
Member

@diogocanut we just merged series/3.5.x into series/3.x so you should be able to finish this PR now. Sorry for my mistake before!

@diogocanut diogocanut marked this pull request as ready for review September 26, 2023 02:46
@diogocanut
Copy link
Contributor Author

@armanbilge done, thanks for noticing.

@Daenyth
Copy link
Contributor

Daenyth commented Oct 2, 2023

bump

@armanbilge armanbilge merged commit 85915dd into typelevel:series/3.x Oct 2, 2023
28 of 29 checks passed
@armanbilge armanbilge mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
🍄 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diogocanut @armanbilge @Daenyth @djspiewak