Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix race condition in Hotswap example #3885

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

armanbilge
Copy link
Member

Fixes #3884.

@armanbilge armanbilge marked this pull request as ready for review October 31, 2023 18:54
Comment on lines +57 to +58
_ <- hs.swap(file(s"$idx.log"))
_ <- hs.get.use(write(_, msg))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a race condition here with the counter and the swapping /shrug

@armanbilge armanbilge changed the title Try to fix race condition in hotswap example Try to fix race condition in Hotswap example Oct 31, 2023
@djspiewak djspiewak merged commit 3589ff9 into series/3.5.x Nov 23, 2023
30 of 34 checks passed
@armanbilge armanbilge changed the title Try to fix race condition in Hotswap example Try to fix race condition in Hotswap example Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants