Prevent Hotswap#get from acquiring a lock when there is no Resource present
#3922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josgarmar28
commented
Dec 28, 2023
armanbilge
reviewed
Dec 29, 2023
armanbilge
reviewed
Dec 29, 2023
armanbilge
reviewed
Dec 31, 2023
armanbilge
reviewed
Dec 31, 2023
armanbilge
reviewed
Dec 31, 2023
Add comment Co-authored-by: Arman Bilge <armanbilge@gmail.com>
armanbilge
reviewed
Jan 8, 2024
Comment on lines
75
to
79
| /** | ||
| * Gets the current resource, if it exists. The returned resource is guaranteed to be | ||
| * available for the duration of the returned resource. | ||
| * Acquires a shared lock to retrieve the current resource, if it exists. The returned | ||
| * resource is guaranteed to be available for its duration. The lock is released if the | ||
| * current resource does not exist. | ||
| */ |
There was a problem hiding this comment.
I think the original comment was okay, the lock is an implementation detail.
Comment on lines
172
to
173
| hs.get.useForever.start *> | ||
| hs.swap(IO.sleep(1.second).toResource) *> |
There was a problem hiding this comment.
We should insert a sleep between these two steps to be sure that the fiber starts. Also I think it's okay to just swap in a Resource.unit, basically we are checking that the swap succeeds and does not hang. If the get above had acquired a shared lock, then the swap would hang due to be unable to obtain an exclusive lock.
Comment on lines
174
to
175
| IO.sleep(2.seconds) *> | ||
| hs.get.use_.timeout(1.second).void |
There was a problem hiding this comment.
I'm not sure if the rest tests anything meaningful.
armanbilge
changed the title
Hotswap#get from acquiring a lock when there is no Resource present
armanbilge
approved these changes
Jan 9, 2024
durban
approved these changes
Jan 9, 2024
@armanbilge Thank you! I appreciate your patience :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3802